FIX: Universal builds on Apple with LLVM Clang#2094
Open
philippremy wants to merge 1 commit into
Open
Conversation
Currently, when building a universal binary on Apple platforms with a supported compiler other than AppleClang (i.e., any other LLVM-derived Clang) will cause the same error as in issue uxlfoundation#1772. This provides a small fix which checks if (1) architectures are cross-compiled on Apple or (2) a universal binary is compiled on Apple. Fall back to the regular CMAKE_SYSTEM_PROCESSOR for non-Apple targets, which used to be the default behavior. Signed-off-by: Philipp Remy <philipp@philippremy.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when building a universal binary on Apple platforms with a supported compiler other than AppleClang (i.e., any other LLVM-derived Clang) this will cause the same error as in issue #1772.
This provides a small fix which checks if (1) architectures are cross-compiled on Apple or (2) a universal binary is compiled on Apple. Fall back to the regular CMAKE_SYSTEM_PROCESSOR for non-Apple targets, which used to be the default behavior. Essentially mimicks the AppleClang detection.
Partly fixes #1772 (should already be fixed for AppleClang).
Type of change
Tests
Documentation
Breaks backward compatibility