Do not link with when symbols are duplicated#2076
Draft
Alexandr-Konovalov wants to merge 5 commits into
Draft
Conversation
Alexandr-Konovalov
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the IntelLLVM Windows CMake compiler settings to avoid linker failures caused by duplicate symbols between Intel’s libmmt.lib and the MSVC UCRT when building 32-bit executables with a static MSVC runtime.
Changes:
- Add a conditional linker workaround for IA-32 +
CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded*to ignorelibmmt.libduring executable linking.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Alexandr-Konovalov
force-pushed
the
dev/Alexandr-Konovalov/already_defined_in_libmmt.lib
branch
from
2a8aa17 to
44bdafc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For IA-32/Intel compiler/CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded* there is a mass linking failure for tests and examples with
libucrt.lib(frexp.obj) : error LNK2005: _frexp already defined in libmmt.lib(frexp_iface_c99.obj)
This PR removed linking with libmmt.lib for the affected configuration.
Type of change
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information