Move to github.com/moby/moby/client from docker/docker#4987
Open
trufflesteeeve wants to merge 2 commits into
Open
Move to github.com/moby/moby/client from docker/docker#4987trufflesteeeve wants to merge 2 commits into
trufflesteeeve wants to merge 2 commits into
Conversation
Moby is the preferred docker client library. The tests were also updated, because image pull options are in a different location. Most of the changes here after updating are from `go mod tidy`.
NewClientWithOptions is deprecated. Also client.WithAPIVersionNegotiation is now the default, so unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moby is the preferred docker client library. The tests were also updated, because image pull options are in a different location.
Most of the changes here after updating are from
go mod tidy.Description:
The goal is to move to an updated docker package. It is only used in tests, so this isn't high priority.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Low Risk
Scope is test-only Docker client wiring and dependency housekeeping; no production scan or auth paths are changed in this diff.
Overview
This PR switches the direct Docker Engine client from
github.com/docker/dockertogithub.com/moby/moby/client(withmoby/moby/api), which is the maintained Moby split of the old monolithic module.The only application code change is in
pkg/sources/docker/docker_test.go: imports and the local-daemon setup now usedockerClient.New(dockerClient.FromEnv)anddockerClient.ImagePullOptionsinstead ofNewClientWithOpts/types/image.PullOptions.go.mod/go.sumreflectgo mod tidy—docker/dockerremains as an indirect dependency (e.g. testcontainers), plus minor bumps (pgregory.net/rapid,docker/go-connections,moby/term,Azure/go-ansiterm).Reviewed by Cursor Bugbot for commit f17ce25. Bugbot is set up for automated code reviews on this repo. Configure here.