feat: add ml/base/kmeans/results/struct-factory#12356
Open
nakul-krishnakumar wants to merge 4 commits into
Open
feat: add ml/base/kmeans/results/struct-factory#12356nakul-krishnakumar wants to merge 4 commits into
ml/base/kmeans/results/struct-factory#12356nakul-krishnakumar wants to merge 4 commits into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Member
Author
|
/stdlib update-copyright-years |
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
Member
Author
| /** | ||
| * Interface describing clustering results. | ||
| */ | ||
| interface Results { |
Member
Author
There was a problem hiding this comment.
Note that stats/base/ztest/two-sample/results/struct-factory uses generics here (and below) as one of the keys in the interface was of type Float64Array or Float32Array
nakul-krishnakumar
added
Machine Learning
Comment on lines
+43
to
+48
| { | ||
| 'name': 'replicates', | ||
| 'description': 'number of times the data was clustered with different initial centroids', | ||
| 'type': 'int64', | ||
| 'castingMode': 'mostly-safe' | ||
| }, |
Member
Author
There was a problem hiding this comment.
Suggested change
| { | |
| 'name': 'replicates', | |
| 'description': 'number of times the data was clustered with different initial centroids', | |
| 'type': 'int64', | |
| 'castingMode': 'mostly-safe' | |
| }, | |
| { | |
| 'name': 'replicates', | |
| 'description': 'number of times the data was clustered with different initial centroids', | |
| 'type': dtype, | |
| 'castingMode': 'mostly-safe' | |
| }, |
Changing all key's (other than enums) data type to dtype from int64 fixed the failing test cases. I understand this happens because javascript doesn't have a integer datatype and uses a common number datatype. So my question is, should I update the data type here from int64 to dtype or should I update testcases to convert the values into int64 before comparing?
Co-authored-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com> Signed-off-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com>
Co-authored-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com> Signed-off-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves None.
Description
This pull request:
ml/base/kmeans/results/struct-factory.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I did not clearly understand what
castingModewas until I consulted ChatGPT.@stdlib-js/reviewers