fix(web): derive over capacity indicator locally from currentUsers vs committedSeats#1250
Closed
msukkari wants to merge 2 commits into
Closed
fix(web): derive over capacity indicator locally from currentUsers vs committedSeats#1250msukkari wants to merge 2 commits into
msukkari wants to merge 2 commits into
Conversation
… committedSeats The yearly seat usage card was showing a live member count (currentUsers) but gating the blue 'over capacity' visual indicator on synced overageSeats from Lighthouse. This created a confusing mismatch where the card would show '2 / 1' with no visual indicator of being over capacity until a Lighthouse sync landed. Changes: - Add isCurrentlyOverCommitted derived locally from currentUsers > committedSeats - Use this local check to show the blue bar segment immediately when over capacity - Add 'Over capacity' badge that appears immediately when over committed - Keep 'Bill pending' badge for when Lighthouse has computed billable overage - Keep peakSeats and billableOverageSeats sourced from Lighthouse (genuinely server-computed and cannot be derived locally) Fixes SOU-1250 Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-1250
Summary
The yearly seat usage card was showing a live member count (
currentUsers) but gating the blue "over capacity" visual indicator on the syncedoverageSeatsvalue from Lighthouse. This created a confusing mismatch where the card would show "2 / 1" with a full-black bar, "0 seats owed", and no blue overage segment until a Lighthouse sync landed.Changes
isCurrentlyOverCommittedderived locally fromcurrentUsers > committedSeatsbillableOverageSeatspeakSeatsandbillableOverageSeatssourced from Lighthouse (genuinely server-computed and cannot be derived locally)Before/After
Testing
Linear Issue: SOU-1250