Skip to content

fix(web): derive over capacity indicator locally from currentUsers vs committedSeats#1250

Closed
msukkari wants to merge 2 commits into
v5from
cursor/fix-yearly-seat-overage-indicator-04dc
Closed

fix(web): derive over capacity indicator locally from currentUsers vs committedSeats#1250
msukkari wants to merge 2 commits into
v5from
cursor/fix-yearly-seat-overage-indicator-04dc

Conversation

@msukkari
Copy link
Copy Markdown
Contributor

Fixes SOU-1250

Summary

The yearly seat usage card was showing a live member count (currentUsers) but gating the blue "over capacity" visual indicator on the synced overageSeats value from Lighthouse. This created a confusing mismatch where the card would show "2 / 1" with a full-black bar, "0 seats owed", and no blue overage segment until a Lighthouse sync landed.

Changes

  • Add isCurrentlyOverCommitted derived locally from currentUsers > committedSeats
  • Use this local check to show the blue bar segment immediately when over capacity
  • Add "Over capacity" badge that appears immediately when over committed (before Lighthouse syncs)
  • Keep "Bill pending" badge for when Lighthouse has computed billableOverageSeats
  • Keep peakSeats and billableOverageSeats sourced from Lighthouse (genuinely server-computed and cannot be derived locally)

Before/After

State Before After
2 users, 1 committed (before sync) "2 / 1", full black bar, no indicator "2 / 1", black+blue bar, "Over capacity" badge
2 users, 1 committed (after sync) "2 / 1", black+blue bar, "Bill pending" badge Same (unchanged)

Testing

  • Lint passes with no new warnings
  • Existing tests pass (unrelated pre-existing failures in v5 branch)

Linear Issue: SOU-1250

Open in Web Open in Cursor 

… committedSeats

The yearly seat usage card was showing a live member count (currentUsers) but
gating the blue 'over capacity' visual indicator on synced overageSeats from
Lighthouse. This created a confusing mismatch where the card would show '2 / 1'
with no visual indicator of being over capacity until a Lighthouse sync landed.

Changes:
- Add isCurrentlyOverCommitted derived locally from currentUsers > committedSeats
- Use this local check to show the blue bar segment immediately when over capacity
- Add 'Over capacity' badge that appears immediately when over committed
- Keep 'Bill pending' badge for when Lighthouse has computed billable overage
- Keep peakSeats and billableOverageSeats sourced from Lighthouse (genuinely
  server-computed and cannot be derived locally)

Fixes SOU-1250

Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fddb4442-4da7-4099-880d-ebb872f7bf94

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-yearly-seat-overage-indicator-04dc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants