Add context information for infer_literal_expr_type#21554
Open
97littleleaf11 wants to merge 2 commits into
Open
Add context information for infer_literal_expr_type#2155497littleleaf11 wants to merge 2 commits into
97littleleaf11 wants to merge 2 commits into
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
sobolevn
reviewed
May 29, 2026
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
The change looks good to me, but I am not sure about the test though :)
It seems overly complex. Is there any other way to test this? Maybe reuse some existing error that shows the line info on the literal type?
Collaborator
Author
|
I don't find any existing test case for this. or I can remove the test case > < |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing context information for literal type. Previous #11754