gh-144774: Add critical section in BaseException.__setstate__#150578
Merged
Conversation
colesbury
reviewed
May 29, 2026
picnixz
changed the title
exceptions.c with PyDict_NextBaseException.__setstate__
Member
Usually a bug fix always includes a NEWS entry, at least to indicate that a crash has been fixed. In this case, it's a data race that has been fixed when an exception is being copied while being mutated. |
Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury
reviewed
May 29, 2026
colesbury
reviewed
May 29, 2026
brijkapadia
commented
May 29, 2026
kumaraditya303
approved these changes
May 30, 2026
Contributor
|
You need to do |
kumaraditya303
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a critical section to prevent a data race in
exceptions.c.Unsure if the test is in the right location.
I don't think that a news entry is necessary.
dictobject.cwhile usingsetattr#144774