Skip to content

gh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME#146006

Open
brijkapadia wants to merge 14 commits into
python:mainfrom
brijkapadia:delete-name
Open

gh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME#146006
brijkapadia wants to merge 14 commits into
python:mainfrom
brijkapadia:delete-name

Conversation

@brijkapadia
Copy link
Copy Markdown
Contributor

@brijkapadia brijkapadia commented Mar 16, 2026 •
edited by github-actions Bot
Loading

Changes

  • Removed DELETE_NAME
  • When STORE_NAME receives a NULL value, it corresponds with deletion

📚 Documentation preview 📚: https://cpython-previews--146006.org.readthedocs.build/

@brijkapadia
pythongh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME
1f97a49 
Changes
- Removed `DELETE_NAME`
- When `STORE_NAME` receives a `NULL` value, it corresponds with
  deletion
@bedevere-app bedevere-app Bot mentioned this pull request Mar 16, 2026
Open
@brijkapadia brijkapadia mentioned this pull request Mar 16, 2026
Draft
@brijkapadia brijkapadia marked this pull request as draft March 16, 2026 02:31
@brijkapadia brijkapadia marked this pull request as ready for review March 16, 2026 10:39
@brijkapadia
Copy link
Copy Markdown
Contributor Author

brijkapadia commented Mar 16, 2026

I am not sure why three of the CIFuzz tests fail. If anyone could help, that would be appreciated.

picnixz
picnixz reviewed Mar 16, 2026
View reviewed changes
Comment thread Python/bytecodes.c Outdated
picnixz
picnixz reviewed Mar 16, 2026
View reviewed changes
Comment thread Python/bytecodes.c Outdated
@markshannon
Copy link
Copy Markdown
Member

markshannon commented Mar 16, 2026

This will need a magic number bump (as do all changes that add or remove opcodes)

@brijkapadia brijkapadia mentioned this pull request Mar 17, 2026
Open
markshannon
markshannon approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this.

@brijkapadia
Copy link
Copy Markdown
Contributor Author

brijkapadia commented Mar 27, 2026

@markshannon A gentle reminder about this PR.

@kumaraditya303
Copy link
Copy Markdown
Contributor

kumaraditya303 commented Apr 16, 2026

A gentle reminder about this PR.

There are merge conflicts.

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Apr 17, 2026 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@brijkapadia
Copy link
Copy Markdown
Contributor Author

brijkapadia commented Apr 17, 2026

@kumaraditya303 Fixed merge conflict for the generated files and magic number

kumaraditya303
kumaraditya303 reviewed Apr 17, 2026
View reviewed changes
Comment thread Include/internal/pycore_magic_number.h Outdated
brijkapadia
brijkapadia commented Apr 17, 2026
View reviewed changes
Comment thread Include/internal/pycore_magic_number.h Outdated
@hugovk hugovk removed their request for review April 17, 2026 14:24
@markshannon
Copy link
Copy Markdown
Member

markshannon commented May 1, 2026

Sorry for leaving this sitting for so long.

I notice that _STORE_NAME is no longer suitable for jitting and is also quite large, so would bloat the stencils if it were.
Can you factor out the body of it into a _PyEval_StoreName() helper function?

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 29, 2026 •
edited
Loading

Documentation build overview

📚 cpython-previews | 🛠️ Build #32907062 | 📁 Comparing 2340680 against main (2a07ff9)

  🔍 Preview build  

155 files changed · + 4 added · ± 151 modified

+ Added

± Modified

@brijkapadia brijkapadia requested a review from markshannon May 29, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brijkapadia @markshannon @kumaraditya303 @picnixz