Skip to content

gh-101675: Fix os Windows-supported file permissions#101694

Open
180909 wants to merge 2 commits into
python:mainfrom
180909:feature/gh-101675
Open

gh-101675: Fix os Windows-supported file permissions#101694
180909 wants to merge 2 commits into
python:mainfrom
180909:feature/gh-101675

Conversation

@180909
Copy link
Copy Markdown
Contributor

@180909 180909 commented Feb 8, 2023

@eryksun
Copy link
Copy Markdown
Contributor

eryksun commented Feb 8, 2023

You missed S_IEXEC. It's used in the st_mode 'permissions' returned by os.stat() for directories and for filenames with an extension that's ".exe", ".com", ".bat", or ".cmd".

This has nothing to do with actual execute permission granted to the file's owner, group, or any user.

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
@read-the-docs-community
Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32915861 | 📁 Comparing fb43ff7 against main (62a45fa)

  🔍 Preview build  

1 file changed
± library/stat.html

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also the stat module docstring (in Modules/_stat.c).

And maybe add the same for S_IEXEC?

Also, I think that S_IREAD should be removed from the os.chmod() documentation. All except S_IWRITE is ignored.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 30, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants