Share chart button#7802
Draft
emilykl wants to merge 8 commits into
Draft
Conversation
emilykl
force-pushed
the
upload-to-cloud-proto
branch
from
a487ce9 to
100da7b
Compare
…ending data to cloud
emilykl
commented
May 29, 2026
|
|
||
| dialog.append('div') | ||
| .classed('plotly-cloud-dialog-title', true) | ||
| .text('Share with Plotly Cloud'); |
Contributor
Author
There was a problem hiding this comment.
All of these strings should (eventually) be wrapped in the localization function (search for Lib._( or _( to find where this is done elsewhere in the codebase)
emilykl
commented
May 29, 2026
Comment on lines
+276
to
+279
| 'Should we include a modebar button that sends this chart to a URL', | ||
| 'specified by `plotlyServerURL`, for sharing the chart with others?', | ||
| 'Note that this button can (depending on `plotlyServerURL` being set)', | ||
| 'send your data to an external server.' |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| 'Should we include a modebar button that sends this chart to a URL', | |
| 'specified by `plotlyServerURL`, for sharing the chart with others?', | |
| 'Note that this button can (depending on `plotlyServerURL` being set)', | |
| 'send your data to an external server.' | |
| 'Should we include a modebar button that sends this chart to a URL', | |
| 'specified by `plotlyServerURL`, for sharing the chart with others?', | |
| 'Note that this button will (after a confirmation step)', | |
| 'send chart data to an external server.' |
emilykl
commented
May 29, 2026
| .style('display', 'none'); | ||
| // Build the request body: the chart JSON plus the plotly.js version used to | ||
| // generate it, so Cloud can host the chart with a compatible plotly.js version. | ||
| var chart = JSON.parse(plots.graphJson(gd, false, 'keepdata')); |
Contributor
Author
There was a problem hiding this comment.
Can avoid serializing and de-serializing by doing this I think
Suggested change
| var chart = JSON.parse(plots.graphJson(gd, false, 'keepdata')); | |
| var chart = plots.graphJson(gd, false, 'keepdata', 'object'); |
emilykl
commented
May 29, 2026
| var cloudWindow = window.open(baseUrl, '_blank'); | ||
| if(!cloudWindow) { | ||
| console.error('Unable to open Plotly Cloud (the popup may have been blocked)'); | ||
| gd.emit('plotly_afterexport'); |
Contributor
Author
There was a problem hiding this comment.
May not want to emit 'plotly_afterexport' in the failure case... maybe a new event, 'plotly_exportfail' or something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codepen: https://codepen.io/emilykl-code/pen/XJNJVZa