Stamps PR builds with preview format: 1.43.0-pr.<build_id>+<commit_hash>#22170
Open
Benjin wants to merge 4 commits into
Open
Stamps PR builds with preview format: 1.43.0-pr.<build_id>+<commit_hash>#22170Benjin wants to merge 4 commits into
1.43.0-pr.<build_id>+<commit_hash>#22170Benjin wants to merge 4 commits into
Conversation
Benjin
requested review from
aasimkhan30,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez and
ssreerama
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds automated pre-release stamping and packaging support so CI-produced VSIXes can be clearly identified as PR/preview builds and packaged using VSCE’s pre-release mechanism.
Changes:
- Added a repo-level stamping script to rewrite each extension’s
package.jsonversion into<version>-<label>.<buildId>+<shortHash>. - Extended the workspace runner and MSSQL packaging script to accept
--preview/--pre-releaseand pass--pre-releasethrough tovsce package. - Updated Azure Pipelines templates and the GitHub Actions workflow to stamp PR builds and package with the pre-release flag.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/workspaces.mjs | Adds --preview/--pre-release parsing and forwards --pre-release during package. |
| scripts/stamp-prerelease-version.mjs | New script to stamp pre-release versions across all extension package.json files. |
| extensions/mssql/scripts/package-extension.js | Adds support for --pre-release and forwards it to vsce package. |
| build/templates/build-sql-database-projects.yml | Packages SqlProj with --preview (pre-release). |
| build/templates/build-mssql.yml | Packages MSSQL online/offline with --preview (pre-release). |
| build/templates/build-database-management-keymap.yml | Packages keymap with --preview (pre-release). |
| build/templates/build-data-workspace.yml | Packages Data Workspace with --preview (pre-release). |
| build/PullRequest.yml | Stamps PR build versions before building/packaging. |
| .github/workflows/build-and-test.yml | Stamps versions and packages with --preview during the workflow. |
Comment on lines
+71
to
+73
| - name: Stamp build as pull request version | ||
| run: | | ||
| node scripts/stamp-prerelease-version.mjs "${{ github.run_id }}" --label pr |
Comment on lines
91
to
94
| - name: Package extensions | ||
| run: | | ||
| npm run package | ||
| npm run package -- --preview | ||
|
|
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22170 +/- ##
=======================================
Coverage 74.85% 74.85%
=======================================
Files 399 399
Lines 123549 123549
Branches 7465 7465
=======================================
Hits 92479 92479
Misses 31070 31070
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding automatic stamping to PR-built VSIXes. Now PR output will be tagged as
prand internal preview builds will be tagged aspreview. All of these will VSIXes will be packaged with the--pre-releaseflagThis PR also moves the stamping script that was previously only in the internal pipelines to here, where it will be used for all pipelines (internal and external).
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines