[api-extractor] Fix internal error when importing a re-exported namespace by name#5810
Open
lukasIO wants to merge 2 commits into
Open
[api-extractor] Fix internal error when importing a re-exported namespace by name#5810lukasIO wants to merge 2 commits into
lukasIO wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree company="LiveKit" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4963:
This happens when a dependency re-exports an entire module as a namespace, e.g.:
and a downstream package imports that namespace by name and references a type within it:
When resolving the utils import,
ExportAnalyzer._fetchAstImport()follows the alias chain, which lands on the re-exported module's source file symbol._fetchAstSymbol()then throws because a SourceFile is not a supported declaration kind.Details
In
_fetchAstImport(), skip fetching anAstSymbolwhen the followed import symbol represents an entire module (aValueModulewhose declaration is aSourceFile). There is noAstSymbolto associate with a whole module, so we leaveastImport.astSymbolundefined— exactly what already happens forimport * as ns from '...'star imports (which passimportSymbol = undefined). The import is still emitted correctly in the rollup.How it was tested
Impacted documentation