Skip to content

Fix OP-TEE client identity handling#885

Draft
sangho2 wants to merge 2 commits into
mainfrom
sanghle/optee/fix_client_identity
Draft

Fix OP-TEE client identity handling#885
sangho2 wants to merge 2 commits into
mainfrom
sanghle/optee/fix_client_identity

Conversation

@sangho2
Copy link
Copy Markdown
Contributor

@sangho2 sangho2 commented May 29, 2026

This PR fixes some bugs of OP-TEE shim's client identity handling. Default client identity is now Public not User. It also does some additional sanity checks.

@sangho2 sangho2 marked this pull request as ready for review May 29, 2026 23:45
@sangho2 sangho2 marked this pull request as draft May 29, 2026 23:52
@sangho2 sangho2 added the must-not-merge:blocked-on-other-changes Other changes/PRs to be handled first. Label not needed for non-main changes. label May 29, 2026
@sangho2
Copy link
Copy Markdown
Contributor Author

sangho2 commented May 30, 2026

We should merge #865 first because this PR should have one more fix: per-session ClientIdenty rather than per-instance ClientIdentity. #865 heavily refactored related data structures and functions.

@github-actions
Copy link
Copy Markdown

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_variant_added.ron

Failed in:
  variant TeeLogin:ReeKernel in /home/runner/work/litebox/litebox/litebox_common_optee/src/lib.rs:850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

must-not-merge:blocked-on-other-changes Other changes/PRs to be handled first. Label not needed for non-main changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant