Add crash dump callback#40674
Draft
kvega005 wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds crash dump callback support for WSLC sessions so SDK callers can be notified after a Linux crash dump is written.
Changes:
- Adds
ICrashDumpCallbackto the WSLC COM IDL and wires it through session settings intoWSLCVirtualMachine. - Adds public SDK callback types and
WslcSetSessionSettingsCrashDumpCallback. - Adds crash dump callback tests for both WSLC COM/session behavior and the C SDK wrapper.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/windows/service/inc/wslc.idl |
Defines the new COM callback interface and adds callback fields to session settings. |
src/windows/service/exe/WSLCSessionManager.cpp |
Passes crash dump callback settings into per-user session initialization. |
src/windows/wslcsession/WSLCVirtualMachine.h |
Stores the optional crash dump callback on the VM object. |
src/windows/wslcsession/WSLCVirtualMachine.cpp |
Invokes the callback after writing a crash dump. |
src/windows/WslcSDK/wslcsdk.h |
Adds public SDK callback types and setter declaration. |
src/windows/WslcSDK/wslcsdk.cpp |
Creates and retains the COM bridge callback and exposes the new setter. |
src/windows/WslcSDK/WslcsdkPrivate.h |
Extends internal session settings and session handle state for the callback. |
src/windows/WslcSDK/CrashDumpCallback.h |
Declares the SDK-to-COM callback bridge. |
src/windows/WslcSDK/CrashDumpCallback.cpp |
Implements the SDK-to-COM callback bridge. |
src/windows/WslcSDK/CMakeLists.txt |
Adds the new callback bridge files to the SDK build. |
src/windows/WslcSDK/wslcsdk.def |
Exports the new callback setter. |
msipackage/package.wix.in |
Registers the new COM interface proxy/stub. |
test/windows/WSLCTests.cpp |
Adds COM-level crash dump callback validation. |
test/windows/WslcSdkTests.cpp |
Adds SDK-level crash dump callback validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Allows users to specify a callback that gets invoked after a crash dump is successfully written.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed