fix(navbar): refresh auth state#1068
Draft
Sbragul26 wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds event listeners for 'focus' and 'pageshow' to trigger user authentication checks on the navbar. The reviewer correctly identified that these events, alongside 'visibilitychange', can trigger concurrent, redundant API requests in rapid succession. They provided a helpful suggestion to implement a flag guarding against concurrent executions.
Contributor
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1068/
|
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #1067
The navbar now updates the login state when the page is reopened or focused, so the user avatar shows automatically after sign-in.