feat(core): add package exports map for ESM subpath resolution#31180
Open
ShaneK wants to merge 3 commits into
Open
feat(core): add package exports map for ESM subpath resolution#31180ShaneK wants to merge 3 commits into
ShaneK wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
force-pushed
the
feat/core-esm-exports
branch
from
8e498d0 to
6528f49
Compare
ShaneK
force-pushed
the
feat/core-esm-exports
branch
from
6528f49 to
3aac420
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30982, resolves #30686, resolves #30730
What is the current behavior?
Core's package.json has no
exportsfield. Webpack and Vite handle that fine, but Node's strict ESM resolver ignores nested package.json files and refuses directory imports. So when the built@ionic/angularbundle doesimport { defineCustomElements } from '@ionic/core/loader'orimport { componentOnReady } from '@ionic/core/components', anything running under Node ESM (Angular 21's default Vitest builder, raw Node, etc.) throwsERR_UNSUPPORTED_DIR_IMPORT. All three resolved issues have the same root problemWhat is the new behavior?
Core's package.json now declares an
exportsmap that covers every directory infileswith explicitindex.jsresolution where directory imports happen, and wildcards for the deep pathsDoes this introduce a breaking change?
When you add
exportsto a package.json, it becomes an allowlist. This means that every undocumented import path will break unless you're usingmoduleResolution: nodeRelated docs PR: ionic-team/ionic-docs#4523
Other information
Apps already on
moduleResolution: "bundler"(Angular 17+ default, Vite default) pick up the fix automatically. Apps on classicmoduleResolution: "node"keep working through the legacy fields and are unaffected.Current dev build: