fix: clarify pending review creation#2569
Open
he-yufeng wants to merge 2 commits into
Open
Conversation
he-yufeng
force-pushed
the
fix/pending-review-tool-copy
branch
from
1f952ed to
5a97566
Compare
Author
|
Rebased the branch onto current Validation after rebase:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_review_writetitle say thatcreateopens a pending reviewmethod: "create"withouteventdoes not submit the reviewFixes #2524.
To verify
UPDATE_TOOLSNAPS=true go test ./pkg/github -run TestCreateAndSubmitPullRequestReview -count=1go test ./pkg/github -run TestCreateAndSubmitPullRequestReview -count=1go test ./pkg/github -count=1go test ./...git diff --check