let devdocs rely ruby 4.0.3,no longer rely ruby 3.x#2680
Conversation
5e5af94 to
ac4d05e
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR attempts to switch the project from Ruby 3.4.8 to Ruby 4.0.5 across the runtime/version pins and regenerates the Gemfile.lock accordingly. It also constrains html-pipeline to ~> 2.14, explicitly adds ostruct and webrick (libraries that have been extracted from the Ruby stdlib), and adds require 'ostruct' to the images filter test.
Changes:
- Bump Ruby version pin to
4.0.5in.ruby-version,Gemfile,Gemfile.lock,Dockerfile, andDockerfile-alpine. - Add
ostructandwebrickgem dependencies and constrainhtml-pipelineto~> 2.14; regenerateGemfile.lock(major upgrades of activesupport, sinatra, rack, etc., and platform-specific entries/CHECKSUMS). - Add
require 'ostruct'totest/lib/docs/filters/core/images_test.rb.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.ruby-version |
Pins Ruby to 4.0.5. |
Gemfile |
Updates Ruby pin to 4.0.5; adds ostruct and webrick; constrains html-pipeline to ~> 2.14. |
Gemfile.lock |
Regenerated lockfile reflecting new Ruby version, multi-platform entries, CHECKSUMS, and upgraded gems. |
Dockerfile |
Updates base image to ruby:4.0.5. |
Dockerfile-alpine |
Updates base image to ruby:4.0.5-alpine. |
test/lib/docs/filters/core/images_test.rb |
Adds explicit require 'ostruct' to support newer Ruby where it's no longer autoloaded. |
Note: Ruby 4.0.5 does not exist as a released version, and no ruby:4.0.5 Docker images are published. The PR title/intent ("rely ruby 4.0.3") is also inconsistent with the actual 4.0.5 pin in the diff. Additionally, .tool-versions (ruby 3.4.8) and README.md (Ruby 3.4.1) still reference older 3.4.x versions and were not updated.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
If you’re adding a new scraper, please ensure that you have:
public/icons/your_scraper_name/directory:16.png: a 16×16 pixel icon for the doc16@2x.png: a 32×32 pixel icon for the docSOURCE: A text file containing the URL to the page the image can be found on or the URL of the original image itselfIf you're updating existing documentation to its latest version, please ensure that you have:
SOURCEfile inpublic/icons/your_scraper_name/are up-to-date if the documentation has a custom iconself.linkscontains up-to-date urls ifself.linksis defined