dhi: refresh migration examples#25210
Open
craig-osterhout wants to merge 1 commit into
Open
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR updates DHI migration examples for Go, Node.js, and Python to use image tags that currently exist. The changes look correct.
Changes reviewed:
- Go: Updated image tags to
golang:1.25-alpine3.23anddhi.io/golang:1.25-alpine3.23 - Node.js: Updated image tags to
node:22-alpine3.23anddhi.io/node:22-alpine3.23; also correctly fixedCMD ["index.js"]for Chainguard/DHI node images (which useENTRYPOINT ["/usr/bin/node"]— the previousCMD ["node", "index.js"]would have producednode node index.js) - Python: Updated image tags to
dhi.io/python:3.13-alpine3.23
No vendored files touched, no pages removed (no redirect concerns), no style violations in added content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current examples use images that no longer exist. Updated examples to images that exist.
Samples to verify with: https://github.com/craig-osterhout/dhi-migration-verify
Related issues or tickets
Reviews