feat(expo): forward secondaryButton theme color to native components#8681
Draft
chriscanin wants to merge 1 commit into
Draft
feat(expo): forward secondaryButton theme color to native components#8681chriscanin wants to merge 1 commit into
chriscanin wants to merge 1 commit into
Conversation
Forward the optional secondaryButton color from the theme JSON through to clerk-ios (ClerkViewFactory) and allow it as a config-plugin theme key. Pairs with the clerk-ios secondaryButton token so social/SSO buttons no longer inherit the page background. MOBILE-528
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 550108f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forwards an optional
secondaryButtontheme color from the native theme JSON through to clerk-ios (ClerkViewFactory) and allows it as a config-plugin theme key. Pairs with clerk/clerk-ios#430 so social/SSO buttons no longer inherit the pagebackground.MOBILE-528
Type of change