-
Notifications
You must be signed in to change notification settings - Fork 455
feat(clerk-js,ui,shared): route <ConfigureSSO /> through org-scoped enterprise_connections #8671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| '@clerk/ui': minor | ||
| '@clerk/shared': minor | ||
| --- | ||
|
|
||
| `<ConfigureSSO />` now calls the org-scoped enterprise connections endpoints via `organization.*EnterpriseConnection*` methods. Previously, the wizard called `user.*EnterpriseConnection*` against the `/me/*` paths. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also let's use the automatic generated snapshot naming with |
||
|
|
||
| Adds two new internal hooks in `@clerk/shared/react`, mirroring the user-scoped variants: | ||
| - `__internal_useOrganizationEnterpriseConnections` | ||
| - `__internal_useOrganizationEnterpriseConnectionTestRuns` | ||
|
|
||
| The existing `__internal_useUserEnterpriseConnections` and `__internal_useEnterpriseConnectionTestRuns` hooks remain available as `@deprecated` aliases. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| '@clerk/clerk-js': minor | ||
| '@clerk/shared': minor | ||
| --- | ||
|
|
||
| Add organization-scoped enterprise connection methods on the `Organization` resource: `getEnterpriseConnections`, `createEnterpriseConnection`, `updateEnterpriseConnection`, `deleteEnterpriseConnection`, `createEnterpriseConnectionTestRun`, and `getEnterpriseConnectionTestRuns`. These hit `/v1/organizations/{org_id}/enterprise_connections/*` and share the same flattened SAML/OIDC request body shape as the existing `User.*` equivalents. | ||
|
|
||
| Renames the parameter types from `Me*` to `Organization*`: | ||
| - `CreateOrganizationEnterpriseConnectionParams` | ||
| - `UpdateOrganizationEnterpriseConnectionParams` | ||
| - `OrganizationEnterpriseConnectionProvider` | ||
| - `OrganizationEnterpriseConnectionSamlInput` | ||
| - `OrganizationEnterpriseConnectionOidcInput` | ||
|
|
||
| The previous `Me*` names remain available as `@deprecated` aliases for backwards compatibility. | ||
|
Comment on lines
+1
to
+15
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can keep all on the same changeset, as those endpoints aren't public on the frontend API as well, it's not like developers were relying on the clerk-js resources for it |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the copy a bit here to denote that this is an internal change, not important for external consumers