Skip to content

test: Fix flaky *_collection_iterate tests with polling helper#831

Merged
vdusek merged 2 commits into
masterfrom
test/fix-flaky-collection-iterate
May 28, 2026
Merged

test: Fix flaky *_collection_iterate tests with polling helper#831
vdusek merged 2 commits into
masterfrom
test/fix-flaky-collection-iterate

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented May 28, 2026

Summary

Tests are still flaky due to eventual consistency - newly created storages aren't immediately visible in the listing endpoint. Adding a polling helper.

Tested with 50 runs, no flakiness.

Failing CI run

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels May 28, 2026
@vdusek vdusek self-assigned this May 28, 2026
@github-actions github-actions Bot added this to the 141st sprint - Tooling team milestone May 28, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label May 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.74%. Comparing base (1f92625) to head (8d4f115).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   94.72%   94.74%   +0.01%     
==========================================
  Files          48       48              
  Lines        5045     5045              
==========================================
+ Hits         4779     4780       +1     
+ Misses        266      265       -1     
Flag Coverage Δ
integration 93.12% <ø> (+0.15%) ⬆️
unit 83.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek marked this pull request as draft May 28, 2026 09:42
@vdusek vdusek marked this pull request as ready for review May 28, 2026 12:06
@vdusek vdusek requested a review from janbuchar May 28, 2026 12:09
Copy link
Copy Markdown
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM

@vdusek vdusek merged commit 9d7b07b into master May 28, 2026
27 checks passed
@vdusek vdusek deleted the test/fix-flaky-collection-iterate branch May 28, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants