GH-33420: [R] Improve error message when providing a mix of readr and Arrow options#50048
GH-33420: [R] Improve error message when providing a mix of readr and Arrow options#50048Rich-T-kid wants to merge 2 commits into
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
@thisisnic could you take a look at this? 🫡 thx |
|
Thanks for the PR @Rich-T-kid! Looks pretty good, just a couple of suggested changes from me:
Give me a shout if you have any question! |
|
@thisisnic / @Jonahkel pushed a PR that updates a test. Could you take another look 😄 |
Hi! Looks good to me! |
|
@thisisnic just wanted to bump this |
Please don't ping maintainers repeatedly. There are some guidelines on project etiquette here: https://community.apache.org/contributors/etiquette.html |
Rationale for this change
closes #33420
What changes are included in this PR?
updates the error message returned
Are these changes tested?
No, minimal change so I don't think its needed
Are there any user-facing changes?
better error responses for users.