docs(sidenav): update responsive example to use current APIs#33318
Open
EduardF1 wants to merge 1 commit into
Open
docs(sidenav): update responsive example to use current APIs#33318EduardF1 wants to merge 1 commit into
EduardF1 wants to merge 1 commit into
Conversation
Replaces the manual MediaMatcher/MediaQueryList setup with the CDK's BreakpointObserver.observe(), which is the idiomatic Angular approach. Uses takeUntilDestroyed() for automatic subscription cleanup, removing the need to implement OnDestroy and manually manage event listeners. Fixes angular#29266 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the responsive sidenav documentation example to use the current CDK APIs instead of deprecated MediaMatcher/MediaQueryList event listener methods.
Root Cause
The example was using MediaMatcher with addEventListener/removeEventListener, which requires manual lifecycle management via OnDestroy. An Angular team member noted the preferred approach is to use the CDK's BreakpointObserver.observe() directly.
Changes
Result
The component is now simpler, idiomatic Angular, and no longer uses the raw MediaQueryList API.
Fixes #29266