Skip to content

fix(connections): persist safe mode level as connection default#1461

Open
J2TeamNNL wants to merge 7 commits into
TableProApp:mainfrom
J2TeamNNL:fix/connections
Open

fix(connections): persist safe mode level as connection default#1461
J2TeamNNL wants to merge 7 commits into
TableProApp:mainfrom
J2TeamNNL:fix/connections

Conversation

@J2TeamNNL
Copy link
Copy Markdown
Contributor

Summary

  • Safe mode changes in the toolbar now persist as the connection default across reconnects
  • Previously only the in-session ConnectionSession.safeModeLevel was updated; ConnectionStorage was never written
  • updateSafeModeLevel follows the save-before-markDirty ordering invariant; skips localOnly and sample connections

Test plan

  • Change safe mode to Read-only, disconnect, reconnect → safe mode is still Read-only
  • Change safe mode back to Off, disconnect, reconnect → safe mode is Off
  • ConnectionStoragePersistenceTests.updateSafeModeLevelWritesThrough passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant