Fix cuda.core and cuda.bindings example links in docs#2156
Draft
uday1o1 wants to merge 1 commit into
Draft
Conversation
Contributor
5767c15 to
9a93adf
Compare
|
For details, open this workflow run and click Summary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cuda.coreandcuda.bindingsGitHub example URLs that used|..._github_ref|substitutions with Sphinxextlinksroles.cuda_core/docs/sourceandcuda_bindings/docs/source.main, while release docs link to the appropriate release tag/ref.Root Cause
The GitHub ref replacements were defined through
rst_epilog, but they were used inside embedded hyperlink URI targets. Sphinx/Docutils left those substitutions literal in generated HTML, so browsers/GitHub saw URLs containing values like|cuda_core_github_ref|or|cuda_bindings_github_ref|. Those are treated as branch/tag names and the links return 404.Validation
latestdocs pages and found the affected pages were limited tocuda.coreandcuda.bindingsdocs pages touched by this PR.cuda.corelatestcuda.corerelease1.0.1cuda.bindingslatestcuda.bindingsrelease13.3.0cuda_core_github_ref,cuda_bindings_github_ref, or encoded%7Ccuda_...refs.git diff --check.