fix(hierarchical-grid): hide child row editing overlay on scroll - master#17302
Open
georgianastasov wants to merge 2 commits into
Open
fix(hierarchical-grid): hide child row editing overlay on scroll - master#17302georgianastasov wants to merge 2 commits into
georgianastasov wants to merge 2 commits into
Conversation
georgianastasov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Hierarchical Grid child row-editing overlay visibility while scrolling, so the overlay doesn’t remain visible outside the grid’s visible area (issue #17275).
Changes:
- Update the Hierarchical Grid scroll handling to re-evaluate child grids’ row-editing overlay visibility during scroll.
- Add a new unit test covering the parent vertical scroll scenario for hiding/showing a child row-editing overlay.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid.component.ts | Adds scroll-time logic to hide/show/reposition child row-edit overlays when the edited row moves in/out of view. |
| projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid.spec.ts | Adds a unit test validating overlay hide/show behavior when parent scrolling moves an edited child row out of view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17275
Description
Fixes an issue in the Hierarchical Grid where the row editing overlay of a child grid could remain visible outside the grid boundaries while scrolling.
The fix updates the child row editing overlay state when scrolling occurs from both relevant scroll surfaces:
When a child grid row currently in edit mode scrolls out of view, its row editing overlay is hidden. When the row scrolls back into view, the overlay is shown again and repositioned correctly.
Motivation / Context
When row editing is started inside a child grid and the user scrolls the parent hierarchical grid, the editing overlay could be pushed outside the visible grid area instead of being hidden together with the child grid.
This caused a visual inconsistency where the overlay appeared detached from the edited row.
The fix ensures that child grid row editing overlays follow the same visibility behavior as the base grid row editing overlay during scroll.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Added unit tests for Hierarchical Grid child row editing overlay behavior during scroll.
Test Configuration:
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)