Skip to content

Commit 33ca03c

Browse files
committed
Bump module path to v2 for breaking Stage interface change
The Stage interface in this series is not backwards compatible: - Start()'s signature changed from: Start(ctx, env, stdin io.ReadCloser) (io.ReadCloser, error) to: Start(ctx, env, stdin io.ReadCloser, stdout io.WriteCloser) error - Stage gained a new required method Preferences(). Callers that only construct stages via the package's exported constructors (Command(), CommandStage(), Function(), ...) are unaffected, but anyone implementing Stage themselves has to update their implementation.
1 parent c15cd4d commit 33ca03c

8 files changed

Lines changed: 9 additions & 9 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
# go-pipe [![GoDoc](https://pkg.go.dev/badge/github.com/github/docs)](https://pkg.go.dev/github.com/github/go-pipe)
1+
# go-pipe [![GoDoc](https://pkg.go.dev/badge/github.com/github/docs)](https://pkg.go.dev/github.com/github/go-pipe/v2)
22
A package used to easily build command pipelines in your Go applications
33

44
# Important
55
We have not thoroughly tested this package on OSs other than Linux, especially Windows. At this time, using this package on Windows based systems is considered experimental and will be supported only on a best effort basis.
66

77
# Links
88

9-
* [Docs](https://pkg.go.dev/github.com/github/go-pipe)
9+
* [Docs](https://pkg.go.dev/github.com/github/go-pipe/v2)

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module github.com/github/go-pipe
1+
module github.com/github/go-pipe/v2
22

33
go 1.24.0
44

internal/ptree/ptree_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99
"strconv"
1010
"testing"
1111

12-
"github.com/github/go-pipe/internal/ptree"
12+
"github.com/github/go-pipe/v2/internal/ptree"
1313
"github.com/stretchr/testify/assert"
1414
"github.com/stretchr/testify/require"
1515
)

pipe/command_linux.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ package pipe
55
import (
66
"context"
77

8-
"github.com/github/go-pipe/internal/ptree"
8+
"github.com/github/go-pipe/v2/internal/ptree"
99
)
1010

1111
// On linux, we can limit or observe memory usage in command stages.

pipe/command_starterror_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
"os/exec"
77
"testing"
88

9-
"github.com/github/go-pipe/pipe"
9+
"github.com/github/go-pipe/v2/pipe"
1010
)
1111

1212
// TestCommandStageStartFailureNoRace verifies that when `cmd.Start()`

pipe/memorylimit_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212
"testing"
1313
"time"
1414

15-
"github.com/github/go-pipe/pipe"
15+
"github.com/github/go-pipe/v2/pipe"
1616
"github.com/stretchr/testify/assert"
1717
"github.com/stretchr/testify/require"
1818
)

pipe/pipe_matching_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77
"os"
88
"testing"
99

10-
"github.com/github/go-pipe/pipe"
10+
"github.com/github/go-pipe/v2/pipe"
1111
"github.com/stretchr/testify/assert"
1212
)
1313

pipe/pipeline_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import (
1818
"github.com/stretchr/testify/require"
1919
"go.uber.org/goleak"
2020

21-
"github.com/github/go-pipe/pipe"
21+
"github.com/github/go-pipe/v2/pipe"
2222
)
2323

2424
// Check whether this package's test suite leaks any goroutines:

0 commit comments

Comments
 (0)